Skip to content

Deprecate functions that were replaced by LabelMap #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdmarshall wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Deprecate functions that were replaced by LabelMap #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ This release marks our first release under the Prometheus umbrella.
- chore: Add copyright license headers and test
- Make cluster and worker-thread metric aggregation order deterministic
- Export `MetricObject`, `MetricObjectWithValues`, `MetricValue` and `MetricValueWithName` from the TypeScript definitions
- chore: Old label processing code marked as deprecated

### Added

Expand Down
8 changes: 8 additions & 0 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ exports.getValueAsString = function getValueString(value) {

/**
* @function removeLabels
* @deprecated please use LabelMap
* @param {Map} hashMap
* @param {string[]} labels
* @param {string[]} sortedLabelNames
Expand All @@ -46,6 +47,7 @@ exports.removeLabels = function removeLabels(

/**
* @function setValue
* @deprecated please use LabelMap
* @param {Map} hashMap
* @param {*} value
* @param {object} labels
Expand All @@ -61,6 +63,7 @@ exports.setValue = function setValue(hashMap, value, labels) {

/**
* @function setValueDelta
* @deprecated please use LabelMap
* @param {Map} hashMap
* @param {*} deltaValue
* @param {object} labels
Expand Down Expand Up @@ -142,6 +145,11 @@ function hashObject(labels, labelNames) {

return fastHashObject(keys, labels);
}

/**
* @deprecated please use LabelMap
* @type {(function(*, *): (string))|*}
*/
exports.hashObject = hashObject;

exports.isObject = function isObject(obj) {
Expand Down
Loading