Open
Conversation
Contributor
Author
|
@geekodour This pr is work in progress. |
weastel
force-pushed
the
automatic_subnet_ids
branch
2 times, most recently
from
8385ec1 to
a4a1554
Compare
Contributor
Author
|
@geekodour This PR ready to be reviewed. |
weastel
changed the title
weastel
force-pushed
the
automatic_subnet_ids
branch
from
96d71bf to
d0bbfe2
Compare
… funcbench Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
…rate eks funcionalities Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
weastel
force-pushed
the
automatic_subnet_ids
branch
from
d0bbfe2 to
596ac75
Compare
geekodour
reviewed
Sep 15, 2020
| } | ||
|
|
||
| // listdownSubnetIds lists all subnet ids for given cluster name, if vpc for given cluster does not exists it creates vpc with given configuration. | ||
| func (c *EKS) listdownSubnetIds(clusterName string) ([]string, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (c *EKS) listdownSubnetIds(clusterName string) ([]string, error) { | |
| func (c *EKS) listSubnetIds(clusterName string) ([]string, error) { |
geekodour
reviewed
Sep 15, 2020
| @@ -1,4 +1,5 @@ | |||
| INFRA_CMD ?= ../infra/infra | |||
| PROVIDER ?= gke | |||
Contributor
There was a problem hiding this comment.
Why are we re-declaring PROVIDER here? :)
| projectid: {{ .GKE_PROJECT_ID }} | ||
| ======= | ||
| projectid: {{ .PROJECT_ID }} | ||
| >>>>>>> Chnage as per review |
Contributor
There was a problem hiding this comment.
Some conflicts didn't get resolved 
Member
|
Do you mind rebasing and fixing old rebase issues? It looks like a super useful change! Thanks! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.