Precipitation calculation with isotherms #99
Conversation
agarciadiego
added
Priority:High
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 97.24% 97.20% -0.05%
==========================================
Files 93 94 +1
Lines 12581 12865 +284
==========================================
+ Hits 12234 12505 +271
- Misses 347 360 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewlee94
left a comment
andrewlee94
left a comment
There was a problem hiding this comment.
A few minor suggestions - I will not formally request changes just in case this is not ready by the time I leave so as not to hold things up with messing around to override my request.
| ) | ||
|
|
||
| self.acid_flow = Var( | ||
| units=units.dimensionless, |
There was a problem hiding this comment.
This looks like it really should have dimensions.
Also, how reliably can be define the upper bound for this (which probably depends on the units)?
|
|
||
| # parameter based on pH 1.5 | ||
| # TODO add surrogate model/equation | ||
| self.E_D = Param( |
There was a problem hiding this comment.
A more descriptive name and/or a doc string would be good here as I do not really know what I am looking at at the moment.
|
|
||
| # parameter based on pH 1.5 | ||
| # TODO add surrogate model/equation | ||
| self.N_D = Param( |
|
Seems like this PR still needs to address Andrew's comments as well as resolving some of the |
|
@agarciadiego, any news on this? |
MarcusHolly
left a comment
MarcusHolly
left a comment
There was a problem hiding this comment.
A few more very minor comments
| dt.report_structural_issues() | ||
| dt.display_overconstrained_set() |
| def test_structural_issues(self, SolEx_frame): | ||
| model = SolEx_frame | ||
| dt = DiagnosticsToolbox(model) | ||
| dt.report_structural_issues() |
| print("Testing Results") | ||
| # scaled_model.fs.precipitator.aqueous_outlet.display() | ||
| scaled_model.fs.precipitator.precipitate_outlet.display() |
There was a problem hiding this comment.
Can remove this (I left it there by accident)
|
|
||
| solve_system(m) | ||
|
|
||
| dt.assert_no_numerical_warnings() |
There was a problem hiding this comment.
This can probably be added back in
8 participants
Addresses Issue:
Lack of prediction from previous precipitation data
Summary/Motivation:
Precipitation requires function to calculate precipitation based on acid dosage
Changes proposed in this PR:
-Adds isotherm form calculation for oxalate precipitation based on acid dosage
-Data based on Visual Minteq
Reviewer's checklist / merge requirements:
mainbranch on the PR author's forkLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
I agree my contributions are submitted under the license terms described in the LICENSE.md file
at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has
rights to intellectual property that includes these contributions, I represent that I have
received permission to make contributions and grant the required license on behalf of that
employer.