feat: transactional fingerprint finalization via FingerprintTransaction (#1926)#1937
Closed
prompt-driven-github[bot] wants to merge 9 commits into
Closed
feat: transactional fingerprint finalization via FingerprintTransaction (#1926)#1937prompt-driven-github[bot] wants to merge 9 commits into
prompt-driven-github[bot] wants to merge 9 commits into
Conversation
…on (#1926) Introduces a single `FingerprintTransaction` context manager that enforces the 'artifact write ⇒ fingerprint write' invariant across all mutating PDD commands (sync, generate, update, auto-deps, fix, CI heal). Replaces scattered `save_fingerprint` call sites with one commit-or-fail code path featuring null-hash guards, atomic temp-file+rename persistence, and `FingerprintFinalizeError` propagation to Click (non-zero exit on failure). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
# Conflicts: # architecture.json
# Conflicts: # architecture.json
Collaborator
|
Verification update for commit
Acceptance evidence:
Remote Linux unit tests, CodeQL, and auto-heal are currently running. |
…ssue-1926 # Conflicts: # .pdd/meta/fingerprint_transaction_python.json # .pdd/meta/fingerprint_transaction_python_run.json
Collaborator
|
Final verification is complete for this campaign fix. GitHub CI
Local verification
The 15 local deselections comprise 9 intentional marker exclusions plus 6 known macOS nested-pytest |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the runtime fix for #1926: one
FingerprintTransactionnow owns fingerprint hash calculation, validation, serialization, and atomic persistence for every mutating PDD path.Closes #1926
What changed
pdd/fingerprint_transaction.pywith canonical payload construction, complete existing-path hash validation, explicit skip semantics, typed diagnostics, and shared crash-safe atomic JSON persistence.save_fingerprint, sync atomic state, one-session sync, generate/example/fix logging, update, auto-deps, metadata sync, CI heal, continuous sync, and the legacy pin-example path through the transaction..pddrcroot.Acceptance criteria
Verification
nothingfor the new fingerprint source set.git diff --check: pass.Stack
This is the base PR for the #1939 schema/mock contract follow-up. That implementation will target
change/issue-1926so the stack remains explicit until this base lands.