test(agentic_common): update Codex model-forwarding regression to gpt-5.6 (#1986)#1990
Open
prompt-driven-github[bot] wants to merge 1 commit into
Open
test(agentic_common): update Codex model-forwarding regression to gpt-5.6 (#1986)#1990prompt-driven-github[bot] wants to merge 1 commit into
prompt-driven-github[bot] wants to merge 1 commit into
Conversation
…-5.6 Replaces the legacy o3-pro example in test_codex_model_env_var_passed_to_cli with gpt-5.6, matching the cloud default set in pdd_cloud#3233. Adds an explicit assertion that --model precedes the exec subcommand, locking in the top-level flag contract required by Codex's CLI. Closes #1986 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_codex_model_env_var_passed_to_clito usegpt-5.6instead of the legacyo3-proexample, matching the cloud default introduced in pdd_cloud#3233.--model gpt-5.6appears before theexecsubcommand, locking in the top-level flag ordering required by Codex's CLI.Test plan
pytest -vv tests/test_agentic_common.py -k codex_model— 1 passedpytest -vv tests/test_agentic_common.py -k codex— 45 passed, 0 failurestest_codex_no_model_env_var_omits_model_flag) unchanged and passingCloses #1986
🤖 Generated with Claude Code