Skip to content

Conversation

@eluce2
Copy link
Collaborator

@eluce2 eluce2 commented Feb 3, 2026

Note

Medium Risk
Changes migration error-handling and FileMaker connection construction, including a new internal _fetchClientOptions passthrough that could affect consumers relying on previous metadata/connection behavior. Risk is moderate and mostly limited to the CLI migration flow and any callers that expected getMetadata to swallow errors.

Overview
Improves the better-auth FileMaker migration CLI by making database/target detection more robust, preserving the original connection’s fetchClientOptions when overriding credentials, and printing a clearer target label.

planMigration/metadata handling is tightened so schema-read failures now throw and are caught at the CLI boundary with a single fatal error message (instead of silently returning null). FMServerConnection now stores fetchClientOptions in an internal _fetchClientOptions field so downstream credential-override flows can inherit non-auth HTTP client configuration.

Written by Cursor Bugbot for commit 5c2cb4b. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
proofkit-docs Ready Ready Preview Feb 3, 2026 10:32pm

Request Review

@eluce2 eluce2 marked this pull request as ready for review February 3, 2026 20:31
Copy link
Collaborator Author

eluce2 commented Feb 3, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/better-auth@113

@proofkit/cli

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/cli@113

create-proofkit

pnpm add https://pkg.pr.new/proofgeist/proofkit/create-proofkit@113

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmdapi@113

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmodata@113

@proofkit/typegen

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/typegen@113

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/webviewer@113

commit: 8c65971

Copy link
Collaborator Author

eluce2 commented Feb 3, 2026

Merge activity

  • Feb 3, 10:31 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 3, 10:33 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 3, 10:33 PM UTC: @eluce2 merged this pull request with Graphite.

@eluce2 eluce2 changed the base branch from 02-03-refactor_better-auth_replace_raw_odata_fetch_with_fmodata_database to graphite-base/113 February 3, 2026 22:31
@eluce2 eluce2 changed the base branch from graphite-base/113 to main February 3, 2026 22:31
@eluce2 eluce2 merged commit d8ff366 into main Feb 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants