feat: implement multiple buttons API with variants #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Runtime emits both decision and experience in evaluated event - Banner plugin auto-renders on experiences:evaluated event - Frequency plugin listens to new event structure - Plugins self-organize by checking experience type - Runtime stays generic and unopinionated - Fix SDK lifecycle management after destroy/init cycle - Update all tests to match new event structure This enables true modularity - adding new experience types (modal, tooltip) only requires adding a plugin, no runtime changes needed.
- Add event examples to Getting Started (tracking, multiple consumers) - Expand API Reference with all SDK events and payloads - Create comprehensive Events Reference page (/reference/events) - Add jstag3, GA4, Segment integration examples - Add CTA button support to banner plugin (text, url, action) - Emit experiences:action events on button clicks - Add dismissable flag to banner content - Update demo with CTA button - Fix dev mode: ESM-only in watch, ESM+IIFE in production - Remove unused imports and fix type issues
- Add priority field to Experience interface (default: 0)
- Implement evaluateAll() method to evaluate all experiences
- Sort by priority (descending), ties maintain registration order
- All matching experiences shown (natural stacking)
- Update plugins to handle array and single event payloads
- Add comprehensive tests for priority sorting and multiple experiences
- Emit single experiences:evaluated event with array of {decision, experience}
- Add buttons array to BannerContent with primary/secondary/link variants - Add responsive layout (desktop inline, mobile stack) - Remove legacy single button property (no backward compat) - Update all tests and documentation - Create comprehensive Plugins reference page - Fix build to exclude docs from SDK build/dev - Clean up outdated doc references BREAKING CHANGE: button property replaced with buttons array
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple Buttons API with Variants
Implements flexible buttons array for banner experiences with visual variants and responsive layout.
Key Changes
Breaking Change:
buttonproperty replaced withbuttonsarrayFeatures
variantandmetadatain action events/reference/pluginsBuild Improvements
pnpm buildandpnpm devnow exclude docs (SDK only)prosdevlab.github.io/experience-sdkTesting
All 138 tests passing