Omit <v/> tag for empty cells with styles#95
Open
abaranovskii wants to merge 1 commit intoprotobi:masterfrom
Open
Omit <v/> tag for empty cells with styles#95abaranovskii wants to merge 1 commit intoprotobi:masterfrom
abaranovskii wants to merge 1 commit intoprotobi:masterfrom
Conversation
abaranovskii
changed the title
<v/> tag for empty cells with styles
abaranovskii
changed the title
<v/> tag for empty cells with styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes PR 8.
If a cell is empty but has styles we need omit
<v/> xml tag at all. Otherwise, Excel will assume that cell contains a value. That might raise error upon further merging such cells in Excel.FYI: @azukaar