Fix MSVC conversion and shadowing warnings (C4267, C4458) - #29235
Open
arman-martirosyan wants to merge 1 commit into
Open
Fix MSVC conversion and shadowing warnings (C4267, C4458)#29235arman-martirosyan wants to merge 1 commit into
arman-martirosyan wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Make size_t narrowing conversions explicit with static_cast and rename shadowing parameters. The casts are safe because the values are bounded by the fields they are assigned to: MicroString sizes are limited by the uint32_t capacity field, map hashes intentionally truncate to map_index_t, and RepeatedPtrField indices and sizes are int internally. Fixes MSVC C4267 in micro_string.h, map.h and repeated_ptr_field.h and C4458 in micro_string.h for every consumer compiling with a high warning level (/W4).
arman-martirosyan
force-pushed
the
msvc-warning-fixes
branch
from
August 18, 2026 12:38
279d247 to
bc1227a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
size_tnarrowing conversions explicit withstatic_castand rename shadowing parameters.The casts are safe because the values are bounded by the fields they are assigned to:
MicroStringsizes are limited by theuint32_tcapacity field, map hashes intentionally truncate tomap_index_t, andRepeatedPtrFieldindices and sizes areintinternally.This fixes MSVC warnings C4267 in
micro_string.h,map.handrepeated_ptr_field.hand C4458 inmicro_string.hfor every consumer that compiles these headers at a high warning level (/W4).