Skip to content

Remove C23 requirement from FastTable. #29254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Draft

Remove C23 requirement from FastTable. #29254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions upb/wire/decode_fast/combinations.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@
#define ENUM_VAL(_, x) kUpb_DecodeFast_##x,

typedef enum {
UPB_DECODEFAST_CARDINALITIES(ENUM_VAL) // kUpb_DecodeFast_Scalar = 0, etc.
UPB_DECODEFAST_CARDINALITIES(ENUM_VAL, _) // kUpb_DecodeFast_Scalar = 0, etc.
} upb_DecodeFast_Cardinality;

typedef enum {
UPB_DECODEFAST_TYPES(ENUM_VAL) // kUpb_DecodeFast_Bool = 0, etc.
UPB_DECODEFAST_TYPES(ENUM_VAL, _) // kUpb_DecodeFast_Bool = 0, etc.
} upb_DecodeFast_Type;

typedef enum {
UPB_DECODEFAST_TAGSIZES(ENUM_VAL) // kUpb_DecodeFast_Tag1Byte = 0, etc.
UPB_DECODEFAST_TAGSIZES(ENUM_VAL, _) // kUpb_DecodeFast_Tag1Byte = 0, etc.
} upb_DecodeFast_TagSize;

#undef ENUM_VAL
Expand All @@ -67,9 +67,9 @@ typedef enum {

enum {
// Counts of the number of enum values for each dimension.
kUpb_DecodeFast_CardinalityCount = UPB_DECODEFAST_CARDINALITIES(ADD),
kUpb_DecodeFast_TypeCount = UPB_DECODEFAST_TYPES(ADD),
kUpb_DecodeFast_TagSizeCount = UPB_DECODEFAST_TAGSIZES(ADD),
kUpb_DecodeFast_CardinalityCount = UPB_DECODEFAST_CARDINALITIES(ADD, _),
kUpb_DecodeFast_TypeCount = UPB_DECODEFAST_TYPES(ADD, _),
kUpb_DecodeFast_TagSizeCount = UPB_DECODEFAST_TAGSIZES(ADD, _),
};

#undef ADD
Expand Down
2 changes: 1 addition & 1 deletion upb/wire/decode_fast/field_parsers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ struct upb_FastDecoder_Return;
UPB_PRESERVE_NONE struct upb_FastDecoder_Return UPB_DECODEFAST_FUNCNAME( \
type, card, size)(PARSE_PARAMS);

UPB_DECODEFAST_FUNCTIONS(F);
UPB_DECODEFAST_FUNCTIONS(F)

UPB_PRESERVE_NONE
struct upb_FastDecoder_Return _upb_FastDecoder_DecodeGeneric(PARSE_PARAMS);
Expand Down
Loading