Converting Code to New API#76
Conversation
- Cleaned up code and converted to easier to use JSON format.
Updated metar.py to include new API
Updated configuration settings for wind and lightning animations, and adjusted daytime dimming options.
gth758y
left a comment
gth758y
left a comment
There was a problem hiding this comment.
Thanks for putting this together. It worked for me, but I'd suggest adding some error handling for incomplete METARs. For instance, VUO is currently not reporting a visibility, which caused this error: ValueError: invalid literal for int() with base 10: ''
… nearest airport flt cat if missing
|
Thanks for the tip! I should have added a more robust section there, just kinda threw something together to get it working. I've added all that functionality and even added a new feature. If REPLACE_CAT_WITH_CLOSEST (a new config option) is set to True, then the code will find the nearest METAR (from your airports list) and show that category so that you don't just have a blank there. |
… it existed in the display airports file
…sion while maintaining airport and display airport integrity. Allowing for changes in config for potential future updates
… reporting field was not being implemented
… forsee a ton of bug potential there.
Add LED and display smoke test to setup script
…es in case others are keeping their own repo
Added version 2.0 details and updated changelog format.
|
Does this still function to date? I am about to finish the wiring on my project i started last summer, but dont want to commit any more time or money if the code is broke. It seems the original dev has abandonded the project and you are the only one trying to keep it alive! |
|
Hey! @emersonsc I kinda just forked the code and made the changes myself so that I could do my own commits / pull requests. My current version is working! At least a few test users have had no issues. You'll find it here along with a readme to follow the directions for install. Hope this helps! |
5 participants
Hi all!
Just noticed my METARMap failing - no idea why it took me so long to notice. Saw a few people offering fixes, but I went a bit more nuclear. The new metar.py should be good to go now and has been working for me, including lightning and wind gusts. I also moved to JSON instead of XML and cleaned up a bunch of the code. Ideally I would have done more but didn't really understand how the external display code worked and didn't want to cause that to break.
Things I was unable to test:
Let me know if anyone sees any issues with the updates! Should hopefully be plug and play, I tried to match both the inputs and outputs of the old code.