-
Notifications
You must be signed in to change notification settings - Fork 0
Add Playwright to dev images #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: munezaclovis <51137458+munezaclovis@users.noreply.github.com>
Co-authored-by: munezaclovis <51137458+munezaclovis@users.noreply.github.com>
|
@copilot checks are failing brev |
Co-authored-by: munezaclovis <51137458+munezaclovis@users.noreply.github.com>
|
@copilot actually Why is pnpm throwing a tamper tantrum even though I have a PNPM_STORE_PATH env variable in env.sh? istead of pnpm setup, I think if we source the env.sh file before installing playwright it should be fine |
Co-authored-by: munezaclovis <51137458+munezaclovis@users.noreply.github.com>
You're right! Changed in 266e97e. Now sourcing |
|
@copilot nvm. seems to not be working lol instead do this make sure the /pnpm can be accessed by all users. this should out the pnpm store inside that directory |
Co-authored-by: munezaclovis <51137458+munezaclovis@users.noreply.github.com>
Summary: Add Playwright to Dev Images ✅
playwrightandpnpxto the DEV_ONLY_BINARIES list in test.phpChanges Made:
Docker Images
PNPM_HOME="/pnpm"and add to PATH, create/pnpmdirectory with 777 permissions for global pnpm packagesPNPM_HOME="/pnpm"and add to PATH, create/pnpmdirectory with 777 permissions for global pnpm packagesTesting
playwrightandpnpxto DEV_ONLY_BINARIES for automated verificationDocumentation
Configuration:
Set
PNPM_HOME="/pnpm"environment variable in the dev stage and create the/pnpmdirectory with full permissions (777) so all users can access it. This allows pnpm to store its global packages in a dedicated directory accessible by all users.Key Features:
--with-depsflagOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.