Skip to content

Add 3 more digits to h5 output files #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesMcClung merged 2 commits into from
Apr 3, 2025
Merged

Add 3 more digits to h5 output files #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
762daa3
output_particles_hdf5_impl: add 3 more digits and a warning
JamesMcClung Mar 31, 2025
86a5073
output_particles_hdf5_impl: drop the _p000000
JamesMcClung Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/libpsc/psc_output_particles/output_particles_hdf5_impl.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,21 @@ public:
abort();
#endif

int slen = strlen(params_.data_dir) + strlen(params_.basename) + 20;
// FIXME there must be a safer way to do this.

// Currently, if timestep has too many digits, the filename string gets
// truncated to e.g. prt.1234567890.h (with .h instead of .h5)

// This is probably a problem with other outputs, too
int slen = strlen(params_.data_dir) + strlen(params_.basename) + 15;
char filename[slen];
snprintf(filename, slen, "%s/%s.%06d_p%06d.h5", params_.data_dir,
params_.basename, timestep, 0);
if (timestep > 999999999) {
LOG_WARN("%s step index exceeds digit limit in file name. Data still "
"written, but file name is truncated.\n",
params_.basename);
}
snprintf(filename, slen, "%s/%s.%09d.h5", params_.data_dir,
params_.basename, timestep);

hid_t file = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, plist);
H5_CHK(file);
Expand Down