Add software based smoothing for non-Lightpack devices #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| virtual void setColorDepth(int); | ||
|
|
||
| protected: | ||
| virtual void setColorsUnsmoothed(const QList<QRgb> & colors) = 0; |
There was a problem hiding this comment.
Looks like there is something wrong with indentation.
Owner
Author
There was a problem hiding this comment.
Yes. This thing is not merge-ready. It is a PR so my CI builds it automatically for testing, but this approach seems to be too much for the device to handle. Additionally, the smoothing algorithm (which I took from the LP firmware) behaves differently when the number of updates is different. I'm still looking for a good solution
psieg
force-pushed
the
master
branch
2 times, most recently
from
9c4bb11 to
af87b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57