Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete FoundationDB-related workarounds and TODOs that are no longer needed after previous fixes, and updates error messages and Deno test commands.
Changes:
- Removed conditional test skips for FoundationDB storage that are no longer necessary
- Re-enabled
ensureReplicationHasNoErrorscalls in replication tests - Removed deprecated FoundationDB query workaround code
- Updated error messages to remove references to deprecated
atomicUpsert()andatomicUpdate()methods - Removed deprecated
--unstableflag from Deno test commands
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/rx-query.test.ts | Removed FoundationDB test skip condition |
| test/unit/replication-protocol.test.ts | Re-enabled error checking for replication in two test cases |
| test/unit/reactive-query.test.ts | Removed FoundationDB test skip conditions from two tests |
| test/unit/attachments-compression.test.ts | Removed Bun CompressionStream compatibility skip condition |
| src/plugins/storage-foundationdb/foundationdb-query.ts | Removed workaround code for FoundationDB keySelector issues |
| src/plugins/dev-mode/error-messages.ts | Updated error messages to remove deprecated method references |
| package.json | Removed deprecated --unstable flag from Deno test commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b9f982b to
5f0ab65
Compare
…should be used (and already are)
5f0ab65 to
a35293f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some miscellaneous edits that I saw while working, as well as addressing a few TODOs (some date back to my work a year ago to fix FoundationDB).