Skip to content

Misc edits#7906

Open
nickchomey wants to merge 5 commits intopubkey:masterfrom
nickchomey:misc-edits
Open

Misc edits#7906
nickchomey wants to merge 5 commits intopubkey:masterfrom
nickchomey:misc-edits

Conversation

@nickchomey
Copy link
Contributor

Just some miscellaneous edits that I saw while working, as well as addressing a few TODOs (some date back to my work a year ago to fix FoundationDB).

Copilot AI review requested due to automatic review settings February 26, 2026 22:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes obsolete FoundationDB-related workarounds and TODOs that are no longer needed after previous fixes, and updates error messages and Deno test commands.

Changes:

  • Removed conditional test skips for FoundationDB storage that are no longer necessary
  • Re-enabled ensureReplicationHasNoErrors calls in replication tests
  • Removed deprecated FoundationDB query workaround code
  • Updated error messages to remove references to deprecated atomicUpsert() and atomicUpdate() methods
  • Removed deprecated --unstable flag from Deno test commands

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/unit/rx-query.test.ts Removed FoundationDB test skip condition
test/unit/replication-protocol.test.ts Re-enabled error checking for replication in two test cases
test/unit/reactive-query.test.ts Removed FoundationDB test skip conditions from two tests
test/unit/attachments-compression.test.ts Removed Bun CompressionStream compatibility skip condition
src/plugins/storage-foundationdb/foundationdb-query.ts Removed workaround code for FoundationDB keySelector issues
src/plugins/dev-mode/error-messages.ts Updated error messages to remove deprecated method references
package.json Removed deprecated --unstable flag from Deno test commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants