WIP feature/TypingIndicator extracted and usable as seperate component#49
Open
mateusz-cichosz wants to merge 1 commit intomasterfrom
Open
WIP feature/TypingIndicator extracted and usable as seperate component#49mateusz-cichosz wants to merge 1 commit intomasterfrom
mateusz-cichosz wants to merge 1 commit intomasterfrom
Conversation
mateusz-cichosz
changed the title
Chesteer89
suggested changes
Oct 17, 2022
| typingIndicatorContent: @Composable ColumnScope.(List<TypingUi>) -> Unit = { typing -> | ||
| TypingIndicatorContent(typing) | ||
| }, | ||
| typingIndicator: @Composable () -> Unit = { TypingIndicator() }, |
Contributor
There was a problem hiding this comment.
Should still use ColumnScope to allow custom modifications based on root layout
Contributor
There was a problem hiding this comment.
The name should stay too. typingIndicator suggest that the instance of indicator will be passed.
| } | ||
| ) { | ||
| Column { | ||
| checkNotNull(LocalChannel.current) |
Contributor
There was a problem hiding this comment.
channel can be extracted as a parameter to allow passing channelId to component
Contributor
|
I think that the feature is invalid. The criteria change the uniform way of transferring data to components. The topic was also not discussed with other teams to maintain similar behavior. IMHO should be rejected. |
Contributor
|
Can we close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.