Move heartbeat call into SharedWorker
#433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass heartbeat request through `SharedWorker`` (if used) to optimize the number of requests for clients opened in few tabs and subscribed on same channels / groups list. refactor(heartbeat): remove redundant `heartbeat` from unsubscribe Don't send `heartbeat` request on unsubscribe.
parfeon
added
status: done
parfeon
changed the title
SharedWorker
mohitpubnub
approved these changes
Jan 30, 2025
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(shared-worker): move heartbeat call into
SharedWorkerPass heartbeat request through
SharedWorker(if used) to optimize the number of requests for clients opened in few tabs and subscribed on same channels / groups list.refactor(heartbeat): remove redundant
heartbeatfrom unsubscribeDon't send
heartbeatrequest to unsubscribe.