Add ability to opt-out smart heartbeat #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `useSmartHeartbeat` configuration option which allows ignoring implicit heartbeat (with successful subscribe response) and keep sending `heartbeat` calls with fixed intervals. feat(shared-worker): configurable offline detection interval `subscriptionWorkerOfflineClientsCheckInterval` configuration option can be used to configure the interval at which “offline” PubNub clients (when tab closed) detection will be done. feat(shared-worker): configurable unsubscribe for offline clients `subscriptionWorkerUnsubscribeOfflineClients` configuration option can be used to force unsubscribe (presence leave) for “offline” PubNub clients (when tab closed). refactor(shared-worker): debug output on request completion When `subscriptionWorkerLogVerbosity` is set, there will be additional output to the page console with information about which clients will be notified about request completion.
parfeon
added
status: done
mohitpubnub
reviewed
Mar 6, 2025
| return true; | ||
| } catch (error) {} | ||
| } catch (error) { | ||
| if (client.workerLogVerbosity) console.error(`[SharedWorker] Unable send message using message port: ${error}`); |
Contributor
There was a problem hiding this comment.
nitpicking may be. Is it typo in log message for message port instead messagepost?
Contributor
Author
There was a problem hiding this comment.
@mohitpubnub no, it is the way how I wrote MessagePort type. I don't think that it is that bad in this form :)
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(heartbeat): add ability to opt-out smart heartbeat
Add
useSmartHeartbeatconfiguration option which allows ignoring implicit heartbeat (with successful subscribe response) and keep sendingheartbeatcalls with fixed intervals.feat(shared-worker): configurable offline detection interval
subscriptionWorkerOfflineClientsCheckIntervalconfiguration option can be used to configure the interval at which “offline” PubNub clients (when tab closed) detection will be done.feat(shared-worker): configurable unsubscribe for offline clients
subscriptionWorkerUnsubscribeOfflineClientsconfiguration option can be used to force unsubscribe(presence leave) for “offline” PubNub clients (when tab closed).
refactor(shared-worker): debug output on request completion
When
subscriptionWorkerLogVerbosityis set, there will be additional output to the page consolewith information about which clients will be notified about request completion.