Fix Shared Worker state update on presence change and listen for pagehide
#445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On `pagehide` without `bfcache` client on page will send `terminate` to Shared Worker for early long-poll request termination and `leave` request sending (if configured). fix(presence): fix channels and groups update in Shared worker Fix an issue with the client's state update in Shared Worker caused by `-pnpres` suffixed entries being removed from heartbeat / leave request channels and groups.
parfeon
added
status: done
mohitpubnub
reviewed
Mar 18, 2025
| pingTimeouts[event.subscriptionKey] = setTimeout( | ||
| pingTimeouts[subscriptionKey] = setTimeout( | ||
| () => pingClients(subscriptionKey), | ||
| interval * 500 - 1, |
Contributor
There was a problem hiding this comment.
Should this be configurable ? Just like we allow heartbeat timing configuration on the top of presence interval value. Or it doesn't matter!!?
Contributor
Author
There was a problem hiding this comment.
@mohitpubnub interval value or what exactly?
Contributor
There was a problem hiding this comment.
Yes, should it be configurable or not?
Contributor
There was a problem hiding this comment.
Got it..subscriptionWorkerOfflineClientsCheckInterval should work for it.
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(shared-worker): early request terminate on
pagehideOn
pagehidewithoutbfcacheclient on page will sendterminateto Shared Worker for early long-poll request termination andleaverequest sending (if configured).fix(presence): fix channels and groups update in Shared worker
Fix an issue with the client's state update in Shared Worker caused by
-pnpressuffixed entries being removed from heartbeat / leave request channels and groups.