Remove minimum presence timeout #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove minimum limit for presence timeout (was 20 seconds) to make it possible specify shorter intervals. fix(shared-worker): fix issue because of which similar requests didn't stacked Fix issue because of which channels not aggregated and caused separate heartbeat requests.
parfeon
added
status: done
mohitpubnub
approved these changes
Mar 20, 2025
| configurationCopy.presenceTimeout = PRESENCE_TIMEOUT_MAXIMUM; | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| 'WARNING: Presence timeout is larger than the maximum. Using maximum value: ', |
Contributor
There was a problem hiding this comment.
Great to have log types. 👍🏻
src/core/interfaces/configuration.ts
Outdated
| ); | ||
| } else if (configurationCopy.presenceTimeout <= 0) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('WARNING: Presence timeout is larger than zero.'); |
Contributor
There was a problem hiding this comment.
nitpick - Shouldn't this be like "Presence timeout should be larger than zero" ? when value is negative or 0
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(presence): remove minimum presence timeout
Remove minimum limit for presence timeout (was 20 seconds) to make it possible specify shorter intervals.
fix(shared-worker): fix issue because of which similar requests didn't stacked
Fix issue because of which channels not aggregated and caused separate heartbeat requests.