Skip to content

Conversation

@parfeon
Copy link
Contributor

@parfeon parfeon commented Apr 10, 2025

feat(publish): compress publish POST body

Compress the published payload if sent by POST.

feat(request): explicit Accept-Encoding header

Explicitly add gzip, deflate to the Accept-Encoding header.

Compress the published payload if sent by POST.

feat(request): explicit `Accept-Encoding` header

Explicitly add `gzip, deflate` to the `Accept-Encoding` header.
@parfeon parfeon added status: done This issue is considered resolved. priority: high This PR should be reviewed ASAP. type: feature This PR contains new feature. labels Apr 10, 2025
@parfeon parfeon self-assigned this Apr 10, 2025
return undefined;
return {
'Accept-Encoding': 'gzip, deflate',
...((this.params?.compressible ?? false) ? { 'Content-Encoding': 'deflate' } : {}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

/**
* Whether `POST` body should be compressed or not.
*/
compressible: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value will be false right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parfeon
Copy link
Contributor Author

parfeon commented Apr 10, 2025

@pubnub-release-bot release

@parfeon parfeon merged commit bee8794 into master Apr 10, 2025
6 of 7 checks passed
@parfeon parfeon deleted the CLEN-2682 branch April 10, 2025 12:53
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: high This PR should be reviewed ASAP. status: done This issue is considered resolved. type: feature This PR contains new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants