Retry policy now applies to all requests and subscription change status emitted #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configured retry policy will be used for any failed request. feat(retry-policy): exponential retry policy used by default for subscribe By default, the SDK is configured to use an exponential retry policy for failed subscribe requests. fix(subscribe): add missing `subscription change` status `PNSubscriptionChangedCategory` will be emitted each time the list of channels and groups is changing. refactor(network): request retries moved to the network Automated request retry has been moved into the network layer to handle all requests (not only subscribed). test(cleanup): make proper clean up after each test case Properly destroy `PubNub` instance after each test case to make sure that all connections closed and prevent tests from hanging.
parfeon
added
status: done
Contributor
|
@parfeon also, with retry - Is event-engine contract feature tests are also good with same old step definitions here ? locally this command should execute tests as per updated contract tests (reconnecting removed version of tests) |
… emitted Add test which tests whether `subscription change` is emitted when subscribing to the new channels.
mohitpubnub
approved these changes
Apr 15, 2025
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Add type, which should be used to completely disable retries. refactor(retry-policy): add information about which APIs belong to endpoint Add more information about which APIs are related to the endpoints, which can be excluded.
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(retry-policy): retry policy now applies to all requests
The configured retry policy will be used for any failed request.
feat(retry-policy): exponential retry policy used by default for subscribe
By default, the SDK is configured to use an exponential retry policy for failed subscribe requests.
fix(subscribe): add missing
subscription changestatusPNSubscriptionChangedCategorywill be emitted each time the list of channels and groups is changing.refactor(network): request retries moved to the network
Automated request retry has been moved into the network layer to handle all requests (not only subscribed).
test(cleanup): make proper clean up after each test case
Properly destroy
PubNubinstance after each test case to make sure that all connections closed and prevent tests from hanging.