Shouldn't retry on bad access denied and bad request #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue because of which client retried for both bad request and access denied. refactor(subscription): add channels and groups to connected status Add current list of channels and groups to connected status.
parfeon
added
status: done
mohitpubnub
approved these changes
Apr 22, 2025
| else if (isExcludedRequest(req, excluded)) return false; | ||
| if (errorCategory) { | ||
| if ( | ||
| errorCategory === StatusCategory.PNCancelledCategory || |
Contributor
There was a problem hiding this comment.
good to see this at one place
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(retry): shouldn't retry on bad access denied and bad request
Fixed issue because of which client retried for both bad request and access denied.
refactor(subscription): add channels and groups to connected status
Add current list of channels and groups to connected status.