feat(spm): add Swift Package Manager build support#469
Open
feat(spm): add Swift Package Manager build support#469
Conversation
Generate public header symlinks in `include/PubNub/` using the `export_for_spm.sh` script with `public-only` mode, configure `Package.swift` with header search paths and fix internal imports that relied on umbrella header transitivity. fix(presence): enforce channel and group uniqueness Replace `NSMutableArray` with `NSMutableSet` in `PNHeartbeat` manager and add `NSSet`-based deduplication in `PNSubscribeRequest` and `PNPresenceHeartbeatRequest` initializers to prevent duplicate channel and channel group entries. feat(tests): add comprehensive unit test suite Add unit tests for concurrency, requests, helpers, models, crypto modules, logger, and network reachability along with error handling and subscribe channel uniqueness tests.
parfeon
added
priority: medium
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(spm): add Swift Package Manager build support
Generate public header symlinks in
include/PubNub/using theexport_for_spm.shscript withpublic-onlymode, configurePackage.swiftwith header search paths and fix internal imports that relied on umbrella header transitivity.fix(presence): enforce channel and group uniqueness
Replace
NSMutableArraywithNSMutableSetinPNHeartbeatmanager and addNSSet-based deduplication inPNSubscribeRequestandPNPresenceHeartbeatRequestinitializers to prevent duplicate channel and channel group entries.feat(tests): add comprehensive unit test suite
Add unit tests for concurrency, requests, helpers, models, crypto modules, logger, and network reachability along with error handling and subscribe channel uniqueness tests.