Base path db constaint - #7952
Draft
mdellweg wants to merge 4 commits into
Draft
Conversation
Member
Author
|
I looked at building an exclusion constraint. But as '^@' is not a symmetric operator, PG won't let me. |
Member
Author
|
And defining a new operator class is a sysadmin only trait in postgres. |
mdellweg
commented
Aug 11, 2026
| slashed_path text := '/' || path || '/'; | ||
| BEGIN | ||
| -- Verify base path is normalized! | ||
| -- i.e. is relative, does not end with '/' and does not contain '//' or '.', '..' segments. |
Member
Author
There was a problem hiding this comment.
Do we also need to restrict the character set?
This introduces a new shallow database type with a check constraint to maintain that all relative paths are sanitized. This also consolidates on the idea what can be allowed as a relative path.
This allows to relieve the tasking system from taking care of base_path sanity.
mdellweg
force-pushed
the
base_path_db_constaint
branch
3 times, most recently
from
August 12, 2026 12:31
063fa04 to
bfe7789
Compare
The base_path integrity is maintained by a database constraint now.
mdellweg
force-pushed
the
base_path_db_constaint
branch
from
August 12, 2026 12:57
bfe7789 to
f2400a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough