Narrow distribution locks with safe base_path protection - #7957
Open
mdellweg wants to merge 1 commit into
Open
Conversation
mdellweg
marked this pull request as ready for review
August 11, 2026 10:21
Member
Author
|
The lb test is failing because pytest-django 4.14.0 is installed, while 4.13.0 dropped support for Django 4.2. How this incompatible combination of versions could ever have been installed is beyond my comprehension. |
Reserve per-distribution locks for ordinary updates while serializing creates and base_path changes on a dedicated domain-scoped distribution.base_path resource. Keep the legacy domain:distributions reservation in shared mode for mixed-version upgrade safety, and move the shared-resource plumbing into the generic async mixins so publication.py only defines the distribution-specific lock policy. Fixes: #3322 Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit d57f727)
mdellweg
force-pushed
the
patchback/backports/3.85/d57f7275e4fb599f5488fe207fb1c8ae4472f4f5/pr-7896
branch
from
August 11, 2026 14:07
557f146 to
f3dfaa5
Compare
mdellweg
enabled auto-merge (rebase)
August 12, 2026 05:16
mdellweg
commented
Aug 12, 2026
Comment on lines
+22
to
+23
| pytest-django!=4.13.0 | ||
| # This version seems not to not have a proper requirement on Django. |
Member
Author
There was a problem hiding this comment.
This made it into the plugin template.
mdellweg
commented
Aug 12, 2026
| aiotools | ||
| pytest<8 | ||
| pytest-django | ||
| pytest-django[django] |
Member
Author
There was a problem hiding this comment.
But this is also needed to make pytest-django depend on the actual django version it is supposed to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve per-distribution locks for ordinary updates while serializing creates and base_path changes on a dedicated domain-scoped distribution.base_path resource. Keep the legacy domain:distributions reservation in shared mode for mixed-version upgrade safety, and move the shared-resource plumbing into the generic async mixins so publication.py only defines the distribution-specific lock policy.
Fixes: #3322
(cherry picked from commit d57f727)
📜 Checklist
See: Pull Request Walkthrough