[PULP-2214] Add relative_path domains - #7959
Open
mdellweg wants to merge 2 commits into
Open
Conversation
mdellweg
force-pushed
the
relative_path_domain
branch
4 times, most recently
from
August 11, 2026 15:18
f4e10a6 to
4482b3f
Compare
This introduces a new shallow database type with a check constraint to maintain that all relative paths are sanitized. This also consolidates on the idea what can be allowed as a relative path.
mdellweg
force-pushed
the
relative_path_domain
branch
from
August 12, 2026 07:00
4482b3f to
9000e8b
Compare
mdellweg
marked this pull request as ready for review
August 12, 2026 07:30
mdellweg
commented
Aug 12, 2026
|
|
||
|
|
||
| CREATE_REL_PATH_DOMAINS = """ | ||
| CREATE OR REPLACE FUNCTION "is_relative_path" ("path" text) RETURNS bool AS $$ |
Member
Author
There was a problem hiding this comment.
Is it still useful to have this function now?
We can also just directly define the domain using the regex check:
CREATE DOMAIN "relative_path" AS text CHECK ('/' || VALUE || '/' !~ '[\n\r\s\t\?#]|(/\.{0,2}/)');Which one would make postgres faster?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new shallow database type with a check constraint to maintain that all relative paths are sanitized.
This also consolidates on the idea what can be allowed as a relative path.
📜 Checklist
See: Pull Request Walkthrough