Conversation
Make it easier for new contributors to get up-and-running quickly by introducing a single script that builds a container with all required dependencies, and allows to easily run any `yarn` command in the project. Signed-off-by: Otto Kekäläinen <otto@kekalainen.net>
|
Thanks for the contribution! I'm not a habitual Docker user, so I'm curious if another contributor (@DeeDeeG?) is willing to give more informed feedback on this than I can muster. |
|
Thank you for taking the time to do all this! I don't believe the currently active team members are using Docker much, and this would be fairly parallel to the CI definitions we do use. I think it's neat and would be happy to point people to this PR if they need a Docker setup to get started. But the likelihood of maintenance on our side feels low, so putting it in the core repo feels like a "wrong location" thing, IMO. (For bitrot concerns, and due to the lack of a code owner among the long-haul established team who can support and explain it well to potential newcomers). Just one opinion and open to hearing other voices from core team and potential / current contributors. |
You do have a Dockerfile (https://github.com/pulsar-edit/pulsar/blob/8da14949c75af2d0779f36acb44487075f56b6cb/Dockerfile) and you haven't removed or maintaned it. As it is most likely not used by anyone, I could add a commit to this PR that deletes that file. |
|
It is my personal hope that the existing Dockerfile is removed on Update: I opened said PR: #1479 |
Make it easier for new contributors to get up-and-running quickly by introducing a single script that builds a container with all required dependencies, and allows to easily run any
yarncommand in the project.You can test this by running e.g.
Demo:
output.mp4