fix(moonbit): register toolchain and fix component build pipeline #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three issues prevented moonbit_wasm_component from building: 1. MoonBit toolchain was never registered - MODULE.bazel declared bazel_dep(name = "rules_moonbit") but never called use_extension or register_toolchains, causing Bazel to use the stub toolchain 2. MOON_HOME not set - moon build couldn't find moonbitlang/core standard library inside the Bazel sandbox 3. Missing sandbox inputs - moonbit_all_files wasn't included in action inputs, so the toolchain binaries (moonc, etc.) weren't available in the sandbox Also adds --encoding utf16 to wasm-tools component embed (required for MoonBit string encoding) and updates rules_moonbit to the commit with chmod + core bundle fixes. Verified: calculator component builds and exports correct WIT: export add: func(a: s32, b: s32) -> s32 export subtract: func(a: s32, b: s32) -> s32 export multiply: func(a: s32, b: s32) -> s32 export divide: func(a: s32, b: s32) -> s32 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
avrabe
force-pushed
the
fix/moonbit-component-toolchain
branch
from
ef147ad to
220c8f5
Compare
Add explicit import of CcToolchainConfigInfo from @rules_cc in both wasi_sdk_toolchain.bzl (generated template) and wasm_cc_toolchain.bzl. Bazel 9 removed CcToolchainConfigInfo as a global built-in, so `provides = [CcToolchainConfigInfo]` evaluates to `provides = [None]` without the import, causing rule definition failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
In Bazel 9, cc_common is no longer a global built-in - it must be explicitly imported from @rules_cc//cc/common:cc_common.bzl. Also switch cc_toolchain_config_lib imports from @bazel_tools to @rules_cc to match the canonical pattern from rules_cc examples. This fixes the "struct has no field create_cc_toolchain_config_info" error when building with Bazel 9. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Bazel 9 removed CcInfo and cc_common from the built-in globals. Add explicit imports from @rules_cc for all files that use them: - cpp/defs.bzl: CcInfo + cc_common - cpp/private/cpp_wasm_binary.bzl: CcInfo - rust/private/rust_wasm_component_bindgen.bzl: CcInfo - test/cpp/cpp_component_tests.bzl: CcInfo These imports are backward-compatible with Bazel 8. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--encoding utf16to wasm-tools component embed (MoonBit string encoding)Test Plan
bazel build //examples/moonbit_component:calculatorsucceedswasm-tools component witshows correct exports (add, subtract, multiply, divide)wasm-tools validatepassesbazel build //examples/moonbit_component:hello_wasistill worksCloses #304
🤖 Generated with Claude Code