(REPLATS-101) Update spec helpers for > 1 image#232
Merged
Conversation
nwolfe
previously approved these changes
Jan 6, 2021
Contributor
Author
|
It looks like this @nwolfe - https://github.com/puppetlabs/pe-console-services/pull/332/files#diff-b13e4282ffe92149a68a4cbed78d882e116b23ea348eed66646b3416a14c36caR10 I think I'm going to go a different direction on the RBAC / console split for now though and stick with producing just one configurable image... so I may end up closing this PR (not that it hurts / breaks anything) |
- require_test_image can now understand a comma separated list of image names given to PUPPET_TEST_DOCKER_IMAGE and will return an array of image names rather than a string when that happens - pull_images can now accept an array of image names to ignore, rather than just a string both changes are backwards compatible
Iristyle
force-pushed
the
update-spec-helpers-for-multiple-images
branch
from
c62e474 to
eb2e142
Compare
Contributor
Author
|
Moved the rbac piece to #254 Turns out this is useful for a case where the same image is used in multiple services (as is the case with puppetlabs/r10k#1143 ... and in pending changes to the puppet-agent test suite at https://github.com/puppetlabs/puppet-agent/pull/2079/files#diff-360a0bbca66cd1f28f3fd1a5f9a3b263eef4f39d9f1afd61dee2198027b936efR9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require_test_image can now understand a comma separated list of
image names given to PUPPET_TEST_DOCKER_IMAGE and will return
an array of image names rather than a string when that happens
pull_images can now accept an array of image names to ignore,
rather than just a string
both changes are backwards compatible