add checksum support to apt::keyring - #1291
Open
milad-zanganeh wants to merge 2 commits into
Open
Conversation
milad-zanganeh
requested review from
a team,
bastelfreak and
smortex
as code owners
July 27, 2026 11:11
Member
|
Thank you @milad-zanganeh for the PR! I have approved the CI to run. It will run the unit tests, but acceptance testing will require the engineering team to do a fork. I'll make sure this gets on the list of work to be reviewed by engineering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
checksumandchecksum_valueparameters to theapt::keyringdefined type and passes them through to the underlyingfileresource.The changes include:
checksumandchecksum_valueparameters.fileresource.Additional Context
This change allows users to specify a checksum when managing keyring files. This is useful in cases where the remote key is republished without any content changes, causing Puppet to replace the file on every run.
checksumandchecksum_valueparameters throughapt::keyringinstead of introducing custom logic, keeping the implementation simple and consistent with the underlyingfileresource.Related Issues (if any)
Fixes: #1196
Checklist
puppet apply)