examples: disable default stats listener - #640
Merged
Merged
Conversation
Collaborator
Author
|
requires #641 |
Member
|
Hey @bastelfreak , I've added #641 into the list for engineering to review, but for this particular PR, was there a scenario that came up that brought this to your attention? Would love some background on this to help with prioritization. |
|
#641 merged. A rebase should trigger unit test and with those passing, I will be happy enough to merge this. |
The examples setup a default stats listener. This will add the `/stats` page to all frontends and expose sensitive information like the amount of backends, haproxy version, internal IP addresses and FQDNs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples setup a default stats listener. This will add the
/statspage to all frontends and expose sensitive information like the amount of backends, haproxy version, internal IP addresses and FQDNs.Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)