-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix noct_sam() #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix noct_sam() #2612
Conversation
|
@cwhanse |
|
@Chirag3841 please merge the current main, this PR is missing the changes made in #2605 |
|
I don't think we want to patch Replacing the argument requires a deprecation. @Chirag3841 if the deprecation machinery is a bit much, OK to close this PR and thanks for attempting the fix. |
@cwhanse
The problem was that 'noct_sam' did not correctly account for the
'effective_irradiance' parameter. The original implementation always used
'poa_global' when computing the initial temperature rise, which caused:
This PR updates 'noct_sam' so that:
New tests were added to validate:
These tests pass under the main branch, confirming correct behaviour.