fix(build): pin react-bootstrap; upgrade to react v15 by gabrielrtakeda · Pull Request #3 · pxpeterxu/react-regexr

gabrielrtakeda · 2020-11-06T19:56:13Z

related: #2

before

Full log

yarn dev
yarn run v1.22.10
$ webpack-dev-server --content-base build/
Project is running at http://localhost:8080/
webpack output is served from /
Content not from webpack is served from /Users/gabrielrtakeda/code/_labs/react-regexr/build
Hash: 24a7b9734117e8fd58e2
Version: webpack 2.7.0
Time: 5573ms
     Asset     Size  Chunks                    Chunk Names
    web.js  1.64 MB       0  [emitted]  [big]  web.js
styles.css  13.9 kB    1, 1  [emitted]         styles.css, styles.css
chunk    {0} web.js (web.js) 1.61 MB [entry] [rendered]
    [0] ./~/process/browser.js 5.43 kB {0} [built]
   [12] ./~/react/index.js 189 bytes {0} [built]
   [14] ./~/react-addons-pure-render-mixin/index.js 429 bytes {0} [built]
   [22] (webpack)-dev-server/client?http://localhost:8080 7.93 kB {0} {1} [built]
   [36] ./~/loglevel/lib/loglevel.js 8.88 kB {0} {1} [built]
   [42] ./~/react-dom/index.js 58 bytes {0} [built]
   [60] ./~/strip-ansi/index.js 161 bytes {0} {1} [built]
   [61] ./~/url/url.js 22.8 kB {0} {1} [built]
   [63] (webpack)-dev-server/client/overlay.js 3.67 kB {0} {1} [built]
   [64] (webpack)-dev-server/client/socket.js 1.08 kB {0} {1} [built]
   [66] (webpack)/hot/emitter.js 74 bytes {0} {1} [built]
   [67] (webpack)/hot nonrecursive ^\.\/log$ 160 bytes {0} {1} [built]
  [104] ./dev/Init.js 273 bytes {0} [built]
  [106] ./dev/MainPage.js 2.84 kB {0} [built]
  [215] multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js 40 bytes {0} [built]
     + 199 hidden modules
chunk    {1} styles.css, styles.css (styles.css) 360 kB [entry] [rendered]
   [22] (webpack)-dev-server/client?http://localhost:8080 7.93 kB {0} {1} [built]
   [31] ./~/ansi-regex/index.js 139 bytes {0} {1} [built]
   [34] ./~/html-entities/lib/index.js 449 bytes {0} {1} [built]
   [36] ./~/loglevel/lib/loglevel.js 8.88 kB {0} {1} [built]
   [37] ./~/node-libs-browser/~/events/events.js 13.5 kB {0} {1} [built]
   [38] ./~/punycode/punycode.js 14.7 kB {0} {1} [built]
   [60] ./~/strip-ansi/index.js 161 bytes {0} {1} [built]
   [61] ./~/url/url.js 22.8 kB {0} {1} [built]
   [62] ./~/url/util.js 315 bytes {0} {1} [built]
   [63] (webpack)-dev-server/client/overlay.js 3.67 kB {0} {1} [built]
   [64] (webpack)-dev-server/client/socket.js 1.08 kB {0} {1} [built]
   [66] (webpack)/hot/emitter.js 74 bytes {0} {1} [built]
   [67] (webpack)/hot nonrecursive ^\.\/log$ 160 bytes {0} {1} [built]
  [105] ./assets/main.scss 41 bytes {1} [built]
  [214] multi (webpack)-dev-server/client?http://localhost:8080 ./assets/main.scss 40 bytes {1} [built]
     + 10 hidden modules

ERROR in ./src/FlagsEditor.js
Module not found: Error: Can't resolve 'react-bootstrap/lib/Overlay' in '/Users/gabrielrtakeda/code/_labs/react-regexr/src'
 @ ./src/FlagsEditor.js 6:14-52
 @ ./src/ExpressionEditor.js
 @ ./dev/MainPage.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/findDOMNode.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/findDOMNode.js 13:24-62
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactMount.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMount.js 17:24-62
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMNullInputValuePropHook.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMNullInputValuePropHook.js 11:29-72
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMUnknownPropertyHook.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMUnknownPropertyHook.js 13:29-72
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMInvalidARIAHook.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMInvalidARIAHook.js 12:29-72
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactMount.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMount.js 15:12-38
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactNodeTypes.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactNodeTypes.js 14:12-38
 @ ./~/react-dom/lib/getHostComponentFromComposite.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDebugTool.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDebugTool.js 14:29-72
 @ ./~/react-dom/lib/ReactInstrumentation.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactUpdateQueue.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactUpdateQueue.js 13:24-62
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/instantiateReactComponent.js
Module not found: Error: Can't resolve 'react/lib/getNextDebugID' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/instantiateReactComponent.js 18:21-56
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMOption.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMOption.js 13:12-38
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactMultiChild.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMultiChild.js 17:24-62
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactCompositeComponent.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactCompositeComponent.js 14:12-38
 @ ./~/react-dom/lib/instantiateReactComponent.js
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactCompositeComponent.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactCompositeComponent.js 16:24-62
 @ ./~/react-dom/lib/instantiateReactComponent.js
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/LinkedValueUtils.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/LinkedValueUtils.js 16:12-38
 @ ./~/react-dom/lib/ReactDOMTextarea.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/flattenChildren.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/flattenChildren.js 24:27-70 40:33-76
 @ ./~/react-dom/lib/ReactMultiChild.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactChildReconciler.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactChildReconciler.js 27:27-70 35:31-74
 @ ./~/react-dom/lib/ReactMultiChild.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/checkReactTypeSpec.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/checkReactTypeSpec.js 27:27-70 69:37-80
 @ ./~/react-dom/lib/ReactCompositeComponent.js
 @ ./~/react-dom/lib/instantiateReactComponent.js
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/traverseAllChildren.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/traverseAllChildren.js 13:24-62
 @ ./~/react-dom/lib/flattenChildren.js
 @ ./~/react-dom/lib/ReactMultiChild.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 72.3 kB [entry] [rendered]
        [0] ./~/css-loader/lib/css-base.js 2.19 kB {0} [built]
        [1] ./~/base64-js/index.js 3.79 kB {0} [built]
        [2] ./~/ieee754/index.js 2.17 kB {0} [built]
        [3] ./~/isarray/index.js 131 bytes {0} [built]
        [4] ./~/node-libs-browser/~/buffer/index.js 48.7 kB {0} [built]
        [5] (webpack)/buildin/global.js 487 bytes {0} [built]
        [6] ./~/css-loader!./~/sass-loader/lib/loader.js?{"includePaths":["/Users/gabrielrtakeda/code/_labs/react-regexr/~/regexr/scss/third-party/compass-mixins"]}!./assets/main.scss 14.8 kB {0} [built]
webpack: Failed to compile.
^[

after

pxpeterxu · 2020-11-09T16:25:03Z

This looks great! Honestly, the only thing I'd change is the React Bootstrap versioning to ^0.33.1, but otherwise, I think this is good to go

gabrielrtakeda · 2020-11-09T18:50:58Z

hi @pxpeterxu thanks for the reply! I've closed the PR before because I used the branch master to replace the react for preact... I found the job you did in this project very nice, exposing the regexr's javascript api to be reusable. Is there any chances to update the project to use the latest version of regexr in similar way that you've did in pxpeterxu/regexr?

I'll update the PR to merge only the part before I replaced the react by preact. I was thinking to create another repo based on this for the preact version.. Do you agree?

5E7EN · 2020-11-26T02:37:05Z

Thanks for this fix, @gabrielrtakeda! Looking forward to the merge...

psiservices-ketan-javia · 2024-02-26T20:31:38Z

@gabrielrtakeda is there any plan to merge this PR to the main repo and release a new version? It's currently unusable when referenced from NPM.

fix(build): pin react-bootstrap; replace react pure mixin

3fb648b

gabrielrtakeda changed the title ~~fix(build): pin react-bootstrap; replace react pure mixin~~ fix(build): pin react-bootstrap; upgrade to react v15 Nov 6, 2020

gabrielrtakeda added 6 commits November 9, 2020 10:32

chore(lib): build

51c8531

chore(deps): upgrade react to v15.6.2

37ebf0b

style(prettier): format file

a821b9b

chore(deps): use prop-types instead of from react directly

5405217

chore(lib): build

a677c18

chore(deps): engine node v10.x

e214dbc

gabrielrtakeda closed this Nov 9, 2020

gabrielrtakeda added 6 commits November 9, 2020 12:32

chore(deps): sort package.json

7bd4e5e

chore(deps): install prettier; prettify all

0401200

chore(deps): add preact; upgrade react-bootstrap

b8971d3

chore(babel): add support for es6 class properties

6058831

chore(react): codemod createClass to es6 class

8a374b5

chore(lib): build

395d884

pxpeterxu reopened this Nov 9, 2020

chore(deps): engine node >= 10.x

3ff5491

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(build): pin react-bootstrap; upgrade to react v15#3

fix(build): pin react-bootstrap; upgrade to react v15#3
gabrielrtakeda wants to merge 14 commits intopxpeterxu:masterfrom
gabrielrtakeda:master

gabrielrtakeda commented Nov 6, 2020 •

edited

Loading

Uh oh!

pxpeterxu commented Nov 9, 2020

Uh oh!

gabrielrtakeda commented Nov 9, 2020 •

edited

Loading

Uh oh!

5E7EN commented Nov 26, 2020 •

edited

Loading

Uh oh!

psiservices-ketan-javia commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gabrielrtakeda commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

before

after

Uh oh!

pxpeterxu commented Nov 9, 2020

Uh oh!

gabrielrtakeda commented Nov 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

5E7EN commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psiservices-ketan-javia commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gabrielrtakeda commented Nov 6, 2020 •

edited

Loading

gabrielrtakeda commented Nov 9, 2020 •

edited

Loading

5E7EN commented Nov 26, 2020 •

edited

Loading