Varying slopes: design operator applies per-observation loadings + term-major coefficient offsets#76
Merged
Merged
Conversation
7628611 to
293c9f1
Compare
…-major offsets (#71)
293c9f1 to
2281c37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #71.
FactorMeta→TermMeta(pure-rename commit first): terms carry an intercept flag plus slope column indices into the frame's continuous columns;Design::newlowers slope-bearingEffects, laid out term-major (offset[t] + c·L_t + level, columns[intercept?, slopes…])gather_term(hot shapes dispatch to it, rare shapes take a fused dynamic fallback); scatter: const-generic multi-column kernels over the existing strategy dispatch —C=1compiles to the previous single-column kernels. Kernel shapes chosen by A/B measurement (1M/5M/20M; arm unification verified tie at 100K–40M). Each direction's dispatch lives with its kernels (gather.rs/scatter.rs)Solver::newrejects solving them (SlopesNotYetSupported) until the transform slices (Varying slopes: single slope on one factor (V=1) — centering + back-transform #59+)