fix: Advection of domain mask for smooth blending at domain edges in reduced-space EnKF #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ens_kalman_filter blending
Co-authored-by: mats-knmi <145579783+mats-knmi@users.noreply.github.com>
Co-authored-by: mats-knmi <145579783+mats-knmi@users.noreply.github.com>
…dar_mask_range is larger than zero
…nd advect domain mask only once
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 83.83% 83.84%
=======================================
Files 168 168
Lines 14621 14630 +9
=======================================
+ Hits 12258 12267 +9
Misses 2363 2363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RubenImhoff
approved these changes
Dec 17, 2025
Contributor
RubenImhoff
left a comment
RubenImhoff
left a comment
There was a problem hiding this comment.
Hi @m-rempel, sorry it took so long, but this looks good! Thanks a lot for finding and solving this bug. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @RubenImhoff and @mats-knmi,
unfortunately, there were still two bugs regarding the advection of the domain mask as well as in the use of the correct timestep for NWP data when it comes to the full utilization of this data.
Now, the domain mask is advected only once per timestep and the correct timestep for the NWP ensemble is used. In addition, there is now also a switch to further return the background ensemble that is used in the correction step to enable further statistics regarding the EnKF.