Skip to content

Re-implement speed benchmarks in pytest-benchmark#5584

Closed
pipliggins wants to merge 7 commits into
pybamm-team:mainfrom
pipliggins:benchmarks-to-pytest
Closed

Re-implement speed benchmarks in pytest-benchmark#5584
pipliggins wants to merge 7 commits into
pybamm-team:mainfrom
pipliggins:benchmarks-to-pytest

Conversation

@pipliggins

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Add an entry under # [Unreleased] in CHANGELOG.md, in one of ## Breaking changes, ## Deprecated, ## Features, or ## Bug fixes (include PR number; breaking and deprecation entries need a one-line migration note). Internal-only PRs — refactor, docs, CI, tests — can skip this. See RELEASE.md for the full policy.

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.08%. Comparing base (a42d7a9) to head (91bb3dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5584   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         339      339           
  Lines       31759    31759           
=======================================
  Hits        31151    31151           
  Misses        608      608           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pipliggins

Copy link
Copy Markdown
Contributor Author

Messed up the merge/rebase locally after the mono-repo PR merged, re-implemented and development continued in #5630

@pipliggins pipliggins closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant