Add arm64 windows native wheel support #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The build_wheels step was skipped but I ran it on my fork and it successfully built. |
Collaborator
neutrinoceros
left a comment
neutrinoceros
left a comment
There was a problem hiding this comment.
Hi @finnagin ! This looks uncontroversial to me, however there's now a merge conflict to resolve. I'd rather avoid stepping on your toes so I'll wait for a couple days for you either to resolve it or ask for assistance. Otherwise I'll do it myself. Thanks !
Co-authored-by: Clément Robert <cr52@protonmail.com>
Co-authored-by: Clément Robert <cr52@protonmail.com>
Contributor
Author
|
Thanks @neutrinoceros! I've resolved the conflict and merged master in. |
Collaborator
|
failures on macos are unrelated, and the relevant jobs passed, so I'll merge this in a minute if I don't discover anything surprising in review |
neutrinoceros
approved these changes
Dec 10, 2025
Collaborator
|
thanks again for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485
This would add windows arm64 tests and builds to
ci.yml.