Draft
Conversation
Use if statements rather than dataclasses or abstract classes
jan-janssen
added
the
format_black
# Conflicts: # atomistics/calculators/ase.py # atomistics/calculators/lammps/calculator.py # atomistics/calculators/lammps/helpers.py # atomistics/calculators/qe.py # atomistics/shared/thermal_expansion.py # atomistics/workflows/elastic/workflow.py # atomistics/workflows/evcurve/workflow.py # atomistics/workflows/phonons/workflow.py
liamhuber
reviewed
Jan 9, 2024
Member
liamhuber
left a comment
liamhuber
left a comment
There was a problem hiding this comment.
This goes back to having strings all over the place, to which I am ideologically opposed.
@samwaseda and I often go back and forth a bunch reviewing PRs trying to convince each other, which is fun and results in some great code improvements. Honestly, here I don't think it's worth your time -- you're unlikely to get me to approve any change introducing this many string checks. If you want to ping others for review I won't be offended, and if there is consensus that this represents an improvement I'll "disagree and commit", but IMO this PR moves backwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use if statements rather than dataclasses or abstract classes