go config: fix symlink resolution in resolveWorkingDir#11
Merged
Conversation
When the config file (e.g. user.taskrunner.json) is a symlink, EvalSymlinks resolves the path to the symlink target's directory instead of the current working directory. This causes fswatch to watch the wrong repo in worktree clones. filepath.Abs alone is sufficient — it resolves relative to cwd without following symlinks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filepath.EvalSymlinksfromresolveWorkingDirso that the working directory resolves relative to the actual cwd, not the symlink targetuser.taskrunner.jsonis symlinked from a worktree clone to the primary repoContext
When running taskrunner from a worktree clone (e.g.
app2), the.envrcsymlinksuser.taskrunner.jsonback to the primary clone (app).EvalSymlinksfollowed this symlink, causingfilepath.Dirto resolve to the primary clone's directory. This meant fswatch watched/Users/jesse/co/appinstead of/Users/jesse/co/app2, so file changes in the worktree never triggered auto-reload.filepath.Absalone is sufficient — it gives the correct absolute path relative to the current working directory without following symlinks.🤖 Generated with Claude Code