Fix interventional/counterfactual terminology conflation in interventional_distribution.ipynb#856
Open
drbenvincent wants to merge 4 commits intomainfrom
Open
Fix interventional/counterfactual terminology conflation in interventional_distribution.ipynb#856drbenvincent wants to merge 4 commits intomainfrom
drbenvincent wants to merge 4 commits intomainfrom
Conversation
Replace "counterfactual questions" with "interventional what-if questions" since the notebook only computes L2 interventional distributions via pm.do, not L3 counterfactuals. Also fix a do-operator notation typo and a grammar error. Closes #855 Made-with: Cursor
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pm.do, not L3 counterfactualsdo-operator notation typo:$P(y|\operatorname{do}=2)$→$P(y|\operatorname{do}(x=2))$Closes #855
Test plan
.ipynband.myst.mdupdated consistentlyMade with Cursor