Numba Dot: Handle complex inputs #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the Numba dot operation's type handling logic to properly support complex number inputs, which were previously mishandled by the casting logic.
Key changes:
- Updated dtype handling to use
numpy_dtypeobjects instead of dtype strings - Added check for float/complex types (
out_dtype.kind not in "fc") to only cast non-float/non-complex types - Added cache versioning to the return values for proper function caching
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pytensor/link/numba/dispatch/elemwise.py |
Fixed dtype casting logic to properly handle complex types by checking dtype.kind and only casting integer types to float; added cache version support; improved verbose logging |
tests/link/numba/test_elemwise.py |
Added test cases for complex128 matrix dot products and mixed int64/complex128 operations to ensure the fix works correctly |
| if x_dtype == dot_dtype and y_dtype == dot_dtype: | ||
| numba_dot_dtype = out_dtype = out.type.numpy_dtype | ||
| if out_dtype.kind not in "fc": | ||
| # Numba alawys returns non-integral outputs, we need to cast to float |
There was a problem hiding this comment.
Typo in comment: "alawys" should be "always".
Suggested change
| # Numba alawys returns non-integral outputs, we need to cast to float | |
| # Numba always returns non-integral outputs, we need to cast to float |
jessegrabowski
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #811
The casting logic did something nonsensical for complex inputs. Fix is simple as they are supported by numba anyway