Numba small fixes follow-up #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
bug
ricardoV94
changed the title
ricardoV94
force-pushed
the
fix_fallback
branch
from
27aea8f to
7e9f420
Compare
ricardoV94
force-pushed
the
fix_fallback
branch
from
7e9f420 to
d558b4c
Compare
Scipy helper doesn't have special handling for ipiv int32 variable, and always assumes it must be cast to a float64
Numba doesn't infer the right type based on the static tuple, but does so with separate boolean variables
ricardoV94
force-pushed
the
fix_fallback
branch
from
d558b4c to
3111d23
Compare
jessegrabowski
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues from #1764 and incomplete #1758