Replace min(blksize, MIN_BLKSIZE) by max(blksize, MIN_BLKSIZE)#287
Open
DerkKooi wants to merge 2 commits intopyscf:masterfrom
Open
Replace min(blksize, MIN_BLKSIZE) by max(blksize, MIN_BLKSIZE)#287DerkKooi wants to merge 2 commits intopyscf:masterfrom
DerkKooi wants to merge 2 commits intopyscf:masterfrom
Conversation
Author
Contributor
|
Hi @DerkKooi, thank you for opening the discussion. When your device has less than 16 GB memory, the default
Can you provide your device info? And how the block sizes are selected for a small system? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numint.pycontains the lineNow either
minorMINhere should be replaced bymax/MAXto make this correct. My suggestion is that it should beblksize = max(blksize, MIN_BLK_SIZE)as right now the behavior is such that that much too small block sizes are selected for small systems. On the other hand, a minimum block size seems like it would run out of memory for larger systems (?).