TDA-ris capable of 30000 nbf (3000 atoms) #615
TDA-ris capable of 30000 nbf (3000 atoms) #615John-zzh wants to merge 44 commits intopyscf:masterfrom
Conversation
What if you replace |
you are right, seems it is really using MKL. In short, and do not use default channel Maybe conda default channel have verison mismatch with contract engine |
|
wired, test_ris.py and test_krylov.py works fine from my side |
gpu4pyscf/tdscf/ris.py
Outdated
| verbose (optional): Verbosity level of the logger. If None, it will use the verbosity of `mf`. | ||
| nto_state (None or int, optional): Which state to calculate natural transition orbitals, | ||
| require install MOKIT https://jeanwsr.gitlab.io/mokit-doc-mdbook/ |
There was a problem hiding this comment.
please use the gitlab url when suggesting installing MOKIT.
gpu4pyscf/tdscf/ris.py
Outdated
| def get_nto(self,state_id): | ||
|
|
||
| ''' need to install MOKIT to dump .fch format orbital file | ||
| https://jeanwsr.gitlab.io/mokit-doc-mdbook/ |
gpu4pyscf/tdscf/ris.py
Outdated
| fchk(nto_mf, fchfilename) | ||
| from mokit.lib.rwwfn import del_dm_in_fch | ||
| del_dm_in_fch(fchname=fchfilename,itype=1) | ||
| return nto_mf |
There was a problem hiding this comment.
I think the get_nto function should only return NTO coeffs, etc. and dump fchk can be done in other functions, to keep the code more organized. Also, in this way it still work when mokit is missing.
There was a problem hiding this comment.
meaning dump fchk in a independent py file, not in GPU4pyscf repo?
There was a problem hiding this comment.
I mean, one function get_nto for calculating and returning NTOs only, like the api provided by tddft, and another save_nto for dumping fchk, which can also be placed in your ris class. Could also have an all-in-one function get_nto_and_save which wraps those two.
If you don't want to split them, making save_fch an option in your current function is also ok i guess, which at least allow people get the NTOs when they don't have mokit.
…capable of 30000 nao 50 states; Krylov in RAM
…cart2sph; fix ABBA krylov residual bug
…fy a value; move RisBase to top of ris.py clear for reading
…s slower than cp.einsum, could be env/compiling issue
|
It seems install from defaults channel also works, with cupy==13.6.0 cutensor ==2.4.1.4 |
…refactor, TODO: verify ECD with ORCA
gpu4pyscf/tdscf/tests/test_ris.py
Outdated
| H -3.22959 2.35981 -0.24953 | ||
| ''' | ||
| mol = gto.M(atom=atom, basis='def2-svp', | ||
| # output = '/dev/null', # Suppress excessive log output |
There was a problem hiding this comment.
Add the output='/dev/null'. stdout.close() causes IO error
…er, it allows reuse many funcs in TDA; the old ABBA solver will be removed in the future
major updates compared to 1.4.1
As of date, some version of MKL-numpy is not compatible with cupy 13.4.1 and cutensor 2.2.0.0, contract engine will complaine about STATUS,
while openblas-numpy-scipy has segmentation fault when solving large FC=SCE.
To use TDA-ris on large system, use