Replace ujson with orjson for JSON serialization #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if self.config is None in _hook to avoid AttributeError when shutdown is called without a prior successful initialize request. Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
- Add exception logging in jedi_completion plugin. - Explicitly disable pylsp_rope in autoimport notebook tests to prevent interference. - Make flake8 argument assertions more flexible to accommodate local configurations. Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
In some environments (e.g. NumPy 2.x on Python 3.13), Jedi might fail to provide completions, definitions, or hover info. Update tests to skip gracefully instead of failing when these libraries cannot be analyzed. Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
- Update pyproject.toml dependencies to require orjson instead of ujson. - Update import fallbacks in pylsp/python_lsp.py, pylsp/__main__.py, and pylsp/plugins/pylint_lint.py. - Handle orjson-specific behavior (bytes output in dumps, absence of load method). Fixes: python-lsp#673 Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"⚠️ Note: This PR is stacked on top of #692. Please review/merge #692 first. I will rebase this onto main once that is merged."
pylsp/plugins/pylint_lint.py.
load method).
Fixes: #673