Fix UnboundLocalError in _border and document rgba() color format #9426
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt rgba() color format The _border helper in ImageOps raised UnboundLocalError when given a tuple with a length other than 2 or 4 (e.g. 1-tuple or 3-tuple). This changes it to raise a clear ValueError instead. Also adds documentation for the rgba() color format in ImageColor, which was supported in code and tested but missing from the docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
radarhere
reviewed
Feb 10, 2026
Member
|
Hi. These seem like two unrelated changes. In the future, it's worth considering whether these should be two separate PRs, or at least two separate commits. I'm not sure how much of this you used AI for, but if you wouldn't mind explaining your human motivation a bit - did you actually find yourself triggering the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug in
ImageOps._border(): When given a tuple with a length other than 2 or 4 (e.g. a 1-tuple or 3-tuple), the function raised an unhelpfulUnboundLocalErrorbecause theleft,top,right,bottomvariables were never assigned. This now raises a clearValueErrorwith a descriptive message instead.Document
rgba()color format inImageColor: Thergba(red, green, blue, alpha)color string format has been supported in code and tested for a long time, but was missing from theImageColordocumentation. This adds it to the list of supported color string formats.Test plan
test_expand_invalid_borderthat verifiesValueErroris raised for 1-tuple, 3-tuple, and 5-tuple border valuesUnboundLocalError🤖 Generated with Claude Code