Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@ include =
omit =
kazoo/tests/*
kazoo/testing/*

# Note - this is a copy of the default exclusions from coverage 7.10.1
[report]
exclude_lines =
#\s*(pragma|PRAGMA)[:\s]?\s*(no|NO)\s*(cover|COVER)
^\s*(((async )?def .*?)?\)(\s*->.*?)?:\s*)?\.\.\.\s*(#|$)
if (typing\.)?TYPE_CHECKING:
28 changes: 21 additions & 7 deletions .flake8
Original file line number Diff line number Diff line change
@@ -1,14 +1,28 @@
[flake8]
builtins = _
exclude =
docs/conf.py,
.git,
__pycache__,
.venv/,venv/,
.tox/,
build/,dist/,*egg,
docs/conf.py,
zookeeper/
# See black's documentation for E203
.venv/,
venv*/,
.tox*/,
build/,
dist/,
*egg,
zookeeper/,

max-line-length = 79
extend-ignore = BLK100,E203

# See black's documentation for E203
#
# I am not sure what version of flake8 hound is using but it gives a lot of

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.0 it seems. I do not reproduce with the pinned version we have (5.0.2).

May I ask for a FIXME to replace hound? I think those errors are important to keep and I found some github actions that could be used instead.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised #774 when I first ran into this.

# undefined names for comments (F821) and redefinition of unused variables
# (F811).
#
# I've also had to supress F401 because you generally also need to specify
# type: ignore and something gets very upset when you have both in the same
# comment.
#
extend-ignore = BLK100,E203,F401,F811,F821

5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,15 @@ zookeeper/
.idea
.project
.pydevproject
.tox
.tox*/
venv*/
/.settings
/.metadata
__pycache__/

!.gitignore
!.git-blame-ignore-revs

.vscode/settings.json
.vscode/
.*_cache/
coverage.xml
6 changes: 6 additions & 0 deletions constraints.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
# Consistent testing environment.
# requirements.txt
eventlet>=0.17.1 ; implementation_name!='pypy'
gevent>=1.2 ; implementation_name!='pypy'

# requirements-dev.txt
black==22.10.0
coverage==6.3.2; python_version=="3.8"
coverage==7.10.7; python_version > "3.8"
flake8==5.0.2
mypy==1.14.1
objgraph==3.5.0
pytest==6.2.5; python_version=="3.8"
pytest==8.4.2; python_version > "3.8"
Expand Down
4 changes: 2 additions & 2 deletions docs/testing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ Example:
from kazoo.testing import KazooTestHarness

class MyTest(KazooTestHarness):
def setUp(self):
def setUp(self) -> None:
self.setup_zookeeper()

def tearDown(self):
def tearDown(self)-> None:
self.teardown_zookeeper()

def testmycode(self):
Expand Down
Loading
Loading