[mypyc] feat: make frozenset literal compilation deterministic [1/1]#19965
Draft
BobTheBuidler wants to merge 11 commits into
Draft
[mypyc] feat: make frozenset literal compilation deterministic [1/1]#19965BobTheBuidler wants to merge 11 commits into
BobTheBuidler wants to merge 11 commits into
Conversation
BobTheBuidler
changed the title
JukkaL
reviewed
Oct 2, 2025
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
This is a good idea -- non-deterministic generated code is a significant problem.
for more information, see https://pre-commit.ci
BobTheBuidler
commented
Oct 2, 2025
|
|
||
| def encoded_frozenset_values(self) -> list[str]: | ||
| return self._encode_collection_values(self.frozenset_literals) | ||
| def sort_frozenset_recursive(frozen: frozenset[object]) -> list[object]: |
Contributor
Author
There was a problem hiding this comment.
maybe I move this even further up and sort them as they're added?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the process of encoding frozenset literals deterministic by sorting the items before encoding.