Fixes #15127: Added optional error code to flag missing return type and tests#19994
Closed
arjunmalkani wants to merge 2 commits into
Closed
Fixes #15127: Added optional error code to flag missing return type and tests#19994arjunmalkani wants to merge 2 commits into
arjunmalkani wants to merge 2 commits into
Conversation
… in semantic analysis file; added tests as well
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Collaborator
|
I'm going to close this in favor of #19125. Please let me know if that is missing something. (In fact, now that you know how to implement parts, you can review that PR!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an optional error code in errorcodes.py which flags missing return type annotations in functions that have annotated parameters. The check runs in semanal.py and ignores init and lambdas. There is also a small unit test file which demonstrates behavior.